Flooding bug is back

Terrain & Mining
amoss [github] · 3 years ago

Issue description

The bug that was fixed in Water inconsistency (unexpected flooding) seems to have come back (or a similar bug still lurks in the code).

There is a square of ocean in the middle of the land that should not be there.
20221212144824_1

When the exavators dig so that it moves it floods out the entire area.
20221212145044_1

To reproduce load this save into 0.4.12e (latest version at current time) and let the exavators dig.
flood_bug.save

Expected behavior

Either no flood at all, or the same amount of water to move lower in the mine, not the entire area to flood out.

Reproduction steps

To reproduce load this save into 0.4.12e (latest version at current time) and let the exavators dig.
flood_bug.save

Game version

v0.4.12e

Files not imported: flood_bug.save

JamieRCHI [github] · 3 years ago

Can it be filled to level 1 first before digging to avoid this? Any area of the maps in the game that have a bit of the map at or below level 0 will cause this. This is the way the game has always worked since I have played it and has never changed. (As far as I know.)

Does this happen in every map? And in any area that has water surrounded by land.
I looked at the other bug and did not see a reference to a specific map.

When they release a map editor, maybe we could fix this?

amoss [github] · 3 years ago

@JamieRCHI [github]
The land in the mine was all above water level to start with, and dug down using the diggers. So there is no point that should have any water in it as a result of digging in dry land.

To work around it in the game I filled the area with the water until it disappear and then re-dug down.

Your questions about other maps don't seem to have any way to test - you would need to know what triggered the presence of water here to be able to test that same condition on a different map. But if you knew what the cause was here then you could fix the bug.

JamieRCHI [github] · 3 years ago

Yes. Not having access to the code would make it difficult to know what really happens in these cases. It would be nice to have a debug mode that would hide or make translucent the water surface so that we could see and possibly identify exactly where and when these things happen. I suspect it happens when the surface representing water gets within a certain tolerance or distance from the ground surface that triggers this. I think the code that detects this and allows it to happen needs to be refined a bit.

j7smith1 [github] · 3 years ago

I have the same issue. Has happened twice but cannot find the trigger. See the screenshot of the flooding - I got it part way through. You can see it is a sufficient distance from the sea. The poor truck is about to be swamped.

Untitled

COI_pic_flood

22 Showing 1–5 of 5